fix: Improve Deployment Process with Documentation and Hosting Plan Updates#358
Merged
Conversation
Avijit-Microsoft
approved these changes
Apr 9, 2025
Contributor
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes changes to documentation and infrastructure configuration to improve the deployment process and update resource specifications.
Documentation Update:
docs/quota_check.md: Added instructions for logging in with Azure CLI before deploying the accelerator.Infrastructure Configuration Updates:
infra/deploy_app_service.bicep: Changed theHostingPlanSkuparameter fromP0v3toB2to update the app service plan.infra/main.json: Updated the Bicep generator version from0.33.93.31351to0.34.44.8038and modified multiple template hashes accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]infra/main.json: Changed the default value of theHostingPlanSkuparameter fromP0v3toB2to align with the updated app service plan.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation